Skip to content

Require QuoteContext for all quotes #6769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2019
Merged

Require QuoteContext for all quotes #6769

merged 1 commit into from
Jul 5, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jun 30, 2019 •
edited
Loading

Mostly add missing implicit QuoteContexts.

@nicolasstucki nicolasstucki self-assigned this Jun 30, 2019
@nicolasstucki nicolasstucki force-pushed the require-quote-context-warining branch 11 times, most recently from b351e73 to dee30ef Compare July 3, 2019 16:46
@nicolasstucki nicolasstucki changed the title Require quote context warning Require QuoteContext for all quotes Jul 3, 2019
@nicolasstucki nicolasstucki force-pushed the require-quote-context-warining branch 10 times, most recently from c8c3d50 to 797c97f Compare July 4, 2019 18:27
@nicolasstucki nicolasstucki force-pushed the require-quote-context-warining branch from 797c97f to 3ac8c5e Compare July 4, 2019 19:04
@nicolasstucki nicolasstucki requested a review from liufengyun July 4, 2019 19:06
@nicolasstucki nicolasstucki marked this pull request as ready for review July 4, 2019 19:40
liufengyun
liufengyun approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This almost justify that Expr/Type should be path-dependent on QuoteContext. But given the usability issues with path-dependent types, current status is good.

@nicolasstucki nicolasstucki merged commit 4c674d2 into scala:master Jul 5, 2019
@nicolasstucki nicolasstucki deleted the require-quote-context-warining branch July 5, 2019 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun